[Benchmarks] Add core benchmarks preset #20688
Open
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
patkamin/core-preset
branch
from
24d3f10 to
2107bed
Compare
PatKamin
force-pushed
the
patkamin/core-preset
branch
from
2107bed to
2e00d9b
Compare
| * If creating a new category, create a new `Suite` class inheriting from `benches.base.Suite`. Implement `name()` and `benchmarks()`. Add necessary `setup()` if the suite requires shared setup. Add group metadata via `additional_metadata()` if needed. | ||
| 3. **Register Suite:** Import and add your new `Suite` instance to the `suites` list in `main.py`. | ||
| 4. **Add to Presets:** If adding a new suite, add its `name()` to the relevant lists in `presets.py` (e.g., "Full", "Normal") so it runs with those presets. Update `README.md` and benchmarking workflow to include the new suite in presets' description/choices. | ||
| 4. **Add to Presets:** If adding a new suite, add its `name()` to the relevant lists in `presets.py` (e.g., "Full", "Normal") so it runs with those presets. Update `README.md` and benchmarking workflow to include the new suite in presets' description/choices. Don't forget to create a new Suite object in `main.py`. |
Contributor
There was a problem hiding this comment.
the new sentence is literally the point no 3. above. So, perhaps re-phrase it a little here, e.g.:
... description/choices. If you're only adding new preset, don't forget ...
|
|
||
| class ComputeBenchCoreSuite(ComputeBench): | ||
| """ | ||
| A suite for core compute benchmarks scenarios for quick runs. |
Contributor
There was a problem hiding this comment.
didn't we expect 100x more runs here?
Add 'Core' Compute Benchmarks preset with SubmitKernel scenarios with the following parameters: - time measurement - all runtimes - out of order/in order queue - with/without measuring completion time - with/without using events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test run: https://github.com/intel/llvm/actions/runs/19532409628/job/55919259615